Kontakt Pflichtfeld

[pcguy]

Halllo zusammen

Ich möchte im Kontaktformular "Ihr Name" als Pflichtfeld einsetzten.
Anscheinend wird die Formularprüfung im contact_us.php abgearbeitet.

Leider reichen meine PHP Kenntnisse nicht aus um die Formularprüfung zu ergänzen 

Kann mir bitte jemand behilflich sein?

Code: PHP  [Auswählen]

<?php
/* -----------------------------------------------------------------------------------------
   $Id: contact_us.php 4321 2013-01-15 16:42:37Z web28 $

   modified eCommerce Shopsoftware
   http://www.modified-shop.org

   Copyright (c) 2009 - 2013 [www.modified-shop.org]
   -----------------------------------------------------------------------------------------
   based on:
   (c) 2006 XT-Commerce

   Released under the GNU General Public License
   ---------------------------------------------------------------------------------------*/

//included by shop_content.php

  //use contact_us.php language file
  require_once (DIR_WS_LANGUAGES.$_SESSION['language'].'/contact_us.php');
 
  $error = false;
  if (isset ($_GET['action']) && ($_GET['action'] == 'send')) {

    //BOF - web28 - 2010-04-03 - New error handling for required fileds
    //jedes Feld kann hier auf die gewünschte Bedingung getestet und eine Fehlermeldung zugeordnet werden
    //BOF error handling
    $err_msg = '';
    if (!xtc_validate_email(trim($_POST['email']))) $err_msg .= ERROR_EMAIL;
    if ((strtoupper($_POST['vvcode']) != $_SESSION['vvcode']) || $_SESSION['vvcode']=='') $err_msg .= ERROR_VVCODE;
    if (trim($_POST['message_body']) == '') $err_msg .= ERROR_MSG_BODY;
    //EOF error handling

    $smarty->assign('error_message', ERROR_MAIL . $err_msg);

    if ($err_msg != '') $error = true;

    //Wenn kein Fehler Email formatieren und absenden
    if (!$error) {
      // Datum und Uhrzeit
      $datum= date("d.m.Y");
      $uhrzeit= date("H:i");

      // BOF - Tomcraft - 2009-11-05 - Advanced contact form (additional fields)
      $additional_fields = '';
      if (isset($_POST['company']))  $additional_fields =  EMAIL_COMPANY. $_POST['company'] . "\n" ;
      if (isset($_POST['street']))   $additional_fields .= EMAIL_STREET . $_POST['street'] . "\n" ;
      if (isset($_POST['postcode'])) $additional_fields .= EMAIL_POSTCODE . $_POST['postcode'] . "\n" ;
      if (isset($_POST['city']))     $additional_fields .= EMAIL_CITY . $_POST['city'] . "\n" ;
      if (isset($_POST['phone']))    $additional_fields .= EMAIL_PHONE . $_POST['phone'] . "\n" ;
      if (isset($_POST['fax']))      $additional_fields .= EMAIL_FAX . $_POST['fax'] . "\n" ;
      // EOF - Tomcraft - 2009-11-05 - Advanced contact form (additional fields)

      // BOF - Tomcraft - 2009-11-05 - Advanced contact form (check for USE_CONTACT_EMAIL_ADDRESS)
      $use_contact_email_query = xtc_db_query("select configuration_value from " . TABLE_CONFIGURATION . " where configuration_key = 'USE_CONTACT_EMAIL_ADDRESS'");
      $use_contact_email = xtc_db_fetch_array($use_contact_email_query);
      if ($use_contact_email['configuration_value'] == 'true') {
          $email = trim(CONTACT_US_EMAIL_ADDRESS);
        $name = CONTACT_US_NAME;
        $notify =  EMAIL_NOTIFY . "\n\n";
      } else {
        $email = trim($_POST['email']);
        $name = $_POST['name'];
        $notify =  '';
      }
      // EOF - Tomcraft - 2009-11-05 - Advanced contact form (check for USE_CONTACT_EMAIL_ADDRESS)

      $email_layout = sprintf(EMAIL_SENT_BY, CONTACT_US_NAME, CONTACT_US_EMAIL_ADDRESS, $datum , $uhrzeit) . "\n" .
              "--------------------------------------------------------------" . "\n" . $notify .
              EMAIL_NAME. $_POST['name'] . "\n" .
              EMAIL_EMAIL. trim($_POST['email']) . "\n" .
              // BOF - Tomcraft - 2009-11-05 - Advanced contact form (additional fields)
              $additional_fields .
              // EOF - Tomcraft - 2009-11-05 - Advanced contact form (additional fields)
              "\n".EMAIL_MESSAGE."\n ". $_POST['message_body'] . "\n";

      xtc_php_mail($email,
             $name,
             CONTACT_US_EMAIL_ADDRESS,
             CONTACT_US_NAME,
             CONTACT_US_FORWARDING_STRING,
             $email,
             $name,
             '',
             '',
             CONTACT_US_EMAIL_SUBJECT,
             nl2br($email_layout),
             $email_layout
             );

      if (!isset ($mail_error)) {
        xtc_redirect(xtc_href_link(FILENAME_CONTENT, 'action=success&coID='.(int) $_GET['coID']));
      } else {
        $smarty->assign('error_message', $mail_error);
      }
    }
    //EOF - web28 - 2010-04-03 - New error handling for required fileds
  }

  $smarty->assign('CONTACT_HEADING', $shop_content_data['content_heading']);
  if (isset ($_GET['action']) && ($_GET['action'] == 'success')) {
    $smarty->assign('success', '1');
    $smarty->assign('BUTTON_CONTINUE', '<a href="'.xtc_href_link(FILENAME_DEFAULT).'">'.xtc_image_button('button_continue.gif', IMAGE_BUTTON_CONTINUE).'</a>');

  } else {
    if ($shop_content_data['content_file'] != '') {
      ob_start();
      if (strpos($shop_content_data['content_file'], '.txt'))
        echo '<pre>';
      include (DIR_FS_CATALOG.'media/content/'.$shop_content_data['content_file']);
      if (strpos($shop_content_data['content_file'], '.txt'))
        echo '</pre>';
    $contact_content = ob_get_contents();
    ob_end_clean();
    } else {
      $contact_content = $shop_content_data['content_text'];
    }
    require (DIR_WS_INCLUDES.'header.php');

    // BOF - Tomcraft - 2009-11-05 - Advanced contact form (fix override by error request)
    if (isset ($_SESSION['customer_id']) && !$error) {
    // EOF - Tomcraft - 2009-11-05 - Advanced contact form (fix override by error request)
      $customers_name = $_SESSION['customer_first_name'].' '.$_SESSION['customer_last_name'];
      // BOF - Dokuman - 2009-09-04: preallocate email address on contact form
      //$email_address = $_SESSION['customer_email_address'];
      $c_query = xtc_db_query("SELECT * FROM ".TABLE_CUSTOMERS." WHERE customers_id='".(int)$_SESSION['customer_id']."'");
      $c_data  = xtc_db_fetch_array($c_query);
      $email_address = stripslashes($c_data['customers_email_address']);
      // EOF - Dokuman - 2009-09-04: preallocate email address on contact form
      // BOF - Tomcraft - 2009-11-05 - Advanced contact form (additional fields)
      $phone   = stripslashes($c_data['customers_telephone']);
      $fax     = stripslashes($c_data['customers_fax']);
      // BOF - Dokuman - 2010-10-14: preallocate additional fields on contact form correctly
      //$company  = stripslashes($c_data['entry_company']);
      //$street   = stripslashes($c_data['entry_street_address']);
      //$postcode = stripslashes($c_data['entry_postcode']);
      //$city     = stripslashes($c_data['entry_city']);
      $address_query = xtc_db_query("select
                        entry_company,
                        entry_street_address,
                        entry_city,
                        entry_postcode
                        from " . TABLE_ADDRESS_BOOK . "
                        where customers_id = '" . (int)$_SESSION['customer_id'] . "'
                        and address_book_id = '" . (int)$_SESSION['customer_default_address_id'] . "'");
      $address_data = xtc_db_fetch_array($address_query);
      $company  = stripslashes($address_data['entry_company']);
      $street   = stripslashes($address_data['entry_street_address']);
      $postcode = stripslashes($address_data['entry_postcode']);
      $city     = stripslashes($address_data['entry_city']);
      // EOF - Dokuman - 2010-10-14: preallocate additional fields on contact form correctly
      // EOF - Tomcraft - 2009-11-05 - Advanced contact form (additional fields)
    } elseif (!$error) {
        $customers_name = '';
        $email_address = '';
        $phone = '';
        $company = '';
        $street = '';
        $postcode = '';
        $city = '';
        $fax = '';
    }

    // BOF - Tomcraft - 2009-11-05 - Advanced contact form (product question)
    $products_info = '';
    // BOF - web28 - 2010-07-14 -  false clamp fixing
    //if (trim($_GET['products_name'] != '')) {$products_info= trim($_GET['products_name']);}
    //if (trim($_GET['products_model'] != '')) {$products_info= trim($products_info . ' - ' . trim($_GET['products_model']));}
    //if ($products_info != '') {$products_info = trim($_GET['question'])."\n" . $products_info . "\n"; }
    if (!empty($_GET['products_name'])) {$products_info = trim($_GET['products_name']);}
    if (!empty($_GET['products_model'])) {$products_info = trim($products_info . ' - ' . trim($_GET['products_model']));}
    if (!empty($_GET['question'])) {$products_question = trim($_GET['question'])."\n";}
    if ($products_info != '') {$products_info = $products_question . $products_info . "\n"; }
    // EOF - web28 - 2010-07-14 -  false clamp fixing
    if (!$error) $message_body = $products_info . "\n";
    // EOF - Tomcraft - 2009-11-05 - Advanced contact form (product question)

    $smarty->assign('CONTACT_CONTENT', $contact_content);
    //BOF - Dokuman - 2009-12-23 - send contact form information with SSL
    //$smarty->assign('FORM_ACTION', xtc_draw_form('contact_us', xtc_href_link(FILENAME_CONTENT, 'action=send&coID='.(int) $_GET['coID'])));
    $smarty->assign('FORM_ACTION', xtc_draw_form('contact_us', xtc_href_link(FILENAME_CONTENT, 'action=send&coID='.(int) $_GET['coID'], 'SSL')));
    //EOF - Dokuman - 2009-12-23 - send contact form information with SSL
    //BOF - web28 - 2009-07-28 - FIX SSL captcha image path
    $smarty->assign('VVIMG', '<img src="'.xtc_href_link(FILENAME_DISPLAY_VVCODES,'','SSL').'" alt="Captcha" />');
    //EOF - web28 - 2009-07-28 - FIX SSL captcha image path
    $smarty->assign('INPUT_CODE', xtc_draw_input_field('vvcode', '', 'size="8" maxlength="6"', 'text', false));
    $smarty->assign('INPUT_NAME', xtc_draw_input_field('name', ($error ? $_POST['name'] : $customers_name), 'size="30"'));
    $smarty->assign('INPUT_EMAIL', xtc_draw_input_field('email', ($error ? $_POST['email'] : $email_address), 'size="30"'));
    // BOF - Tomcraft - 2009-11-05 - Advanced contact form (additional fields)
    $smarty->assign('INPUT_PHONE', xtc_draw_input_field('phone', ($error ? $_POST['phone'] : $phone), 'size="30"'));
    $smarty->assign('INPUT_COMPANY', xtc_draw_input_field('company', ($error ? $_POST['company'] : $company), 'size="30"'));
    $smarty->assign('INPUT_STREET', xtc_draw_input_field('street', ($error ? $_POST['street'] : $street), 'size="30"'));
    $smarty->assign('INPUT_POSTCODE', xtc_draw_input_field('postcode', ($error ? $_POST['postcode'] : $postcode), 'size="30"'));
    $smarty->assign('INPUT_CITY', xtc_draw_input_field('city', ($error ? $_POST['city'] : $city), 'size="30"'));
    $smarty->assign('INPUT_FAX', xtc_draw_input_field('fax', ($error ? $_POST['fax'] : $fax), 'size="30"'));
    // EOF - Tomcraft - 2009-11-05 - Advanced contact form (additional fields)
    // BOF - Tomcraft - 2009-09-29 - fixed word-wrap in contact-form
    //$smarty->assign('INPUT_TEXT', xtc_draw_textarea_field('message_body', 'soft', 50, 15, ($error ? xtc_db_input($_POST['message_body']) : $first_name)));
    // BOF - Tomcraft - 2010-02-18 - Fixed width of textarea in FireFox under Linux.
    //$smarty->assign('INPUT_TEXT', xtc_draw_textarea_field('message_body', 'soft', 50, 15, ($error ? $_POST['message_body'] : $message_body)));
    $smarty->assign('INPUT_TEXT', xtc_draw_textarea_field('message_body', 'soft', 45, 15, ($error ? $_POST['message_body'] : $message_body)));
    // EOF - Tomcraft - 2010-02-18 - Fixed width of textarea in FireFox under Linux.
    // EOF - Tomcraft - 2009-09-29 - fixed word-wrap in contact-form
    $smarty->assign('BUTTON_SUBMIT', xtc_image_submit('button_send.gif', IMAGE_BUTTON_SEND));
    $smarty->assign('FORM_END', '</form>');
  }

  $smarty->assign('language', $_SESSION['language']);
  $smarty->caching = 0;
  $main_content = $smarty->fetch(CURRENT_TEMPLATE.'/module/contact_us.html');
?>



 

Linkback: https://www.modified-shop.org/forum/index.php?topic=32097.0

[Kawabiker]

Auf die Schnelle einsprachig:

suche:

Code: PHP  [Auswählen]

$err_msg = '';

füge danach ein:

Code: PHP  [Auswählen]

        if (trim($_POST['name']) == '') $err_msg .= '<br /><b>Ihr Name:</b> Keine Eingabe!';

[pcguy]

Danke für die schnelle Antwort!

Die Fehlermeldung erscheint aber nun auch wenn das Feld korreckt ausgefüllt ist?

Kann es sein das am Feld was nicht stimmt?

Code: PHP  [Auswählen]

<label class="col-sm-3 control-label">{#text_name#}</label>
   <div class="col-sm-9">{$INPUT_NAME|replace:'<input type':'<input class="form-control" type'|regex_replace:'/size.*"/':''}</div>
 

[Kawabiker]

Das ist aber nicht mehr das Original-Template...  :

Das würde so aussehen:

Code: PHP  [Auswählen]

        <tr>
                  <td width="41%">{#text_name#}</td>
                  <td width="59%">{$INPUT_NAME}</td>
                </tr>
 

Dann schau mal hier noch rein:

http://www.modified-shop.org/forum/index.php?topic=9171.0

[pcguy]

Ja, es handelt sich um das Bootstrap Template.

Danke, aber das wird mir zu kompliziert .... ich frage mich warum der Name nicht Original bereits ein Pflichtfeld ist ....

[pcguy]

So ... habe es doch noch hinbekommen .... für alle die das selbe Problem haben:

die Codezeile einbauen:

Code: PHP  [Auswählen]

if (trim($_POST['name']) == '') $err_msg .= ERROR_Name;

In etwa an dieser Stelle:

Code: PHP  [Auswählen]

//BOF - web28 - 2010-04-03 - New error handling for required fileds
    //jedes Feld kann hier auf die gewünschte Bedingung getestet und eine Fehlermeldung zugeordnet werden
    //BOF error handling
    $err_msg = '';
        if (trim($_POST['name']) == '') $err_msg .= ERROR_Name;
    if (!xtc_validate_email(trim($_POST['email']))) $err_msg .= ERROR_EMAIL;
    if ((strtoupper($_POST['vvcode']) != $_SESSION['vvcode']) || $_SESSION['vvcode']=='') $err_msg .= ERROR_VVCODE;
    if (trim($_POST['message_body']) == '') $err_msg .= ERROR_MSG_BODY;
    //EOF error handling

In der Sprachdatei lang/german/modules/contact_us.php
nach  //contact-form error messages

Code: PHP  [Auswählen]

 define('ERROR_Name','<p><b>Ihr Name:</b> Keine oder ung&uuml;ltige Eingabe!</p>');
 

hinzufügen

[sixtyseven]

Vielen Dank, genau das, was ich gerade brauche. In meinem Falle wäre es allerdings das Telefonnummern-Feld, das Name-Feld werde ich bei dieser Gelegenheit gleich mit zum Pflichtfeld machen.

In diesem Zusammenhang: Eine Validierung der Telefonnummer wäre nett. Hier habe ich dazu was gefunden:

Code: PHP  [Auswählen]

$telephone = preg_replace('/[^0-9]/', '', $telephone);

bzw.

Code: PHP  [Auswählen]

$telephone = preg_replace('/[^0-9+-]/', '', $telephone);

Vielleicht ist hier aber eine etwas komplexere Expression angebracht:

Code: PHP  [Auswählen]

$telephone = preg_replace('/^(([^\.\-\,a-wy-z]([\(]?(\+|[x])?\d+[\)]?)?[\s\.\-\,]?([\(]?\d+[\)]?)?[\s\.\-\,]?(\d+[\s\.\-\,]?)+[^\.\-\,a-z])|((\+|[x])?\d+))$/i', '', $telephone);

Quelle: hier.

Sollte die meisten Schreibweisen (Klammern, 0049, +49, Punkte, etc.) internationaler Nummern abdecken. Mir fehlt hier eigentlich nur noch der Schrägstrich, so würde z.B. ich eine Vorwahl von der Nummer trennen. Leider habe ich es nicht so mit regex, kann da mal jemand drüber schauen und mir das ggf. verbessern?

Schon mal besten Dank im Voraus

[sixtyseven]

Die regex ist vielleicht doch ein wenig überdimensioniert. So habe ich es jetzt gelöst:

in contact_us.php suchen:

Code: PHP  [Auswählen]

$err_msg = '';

Darunter einfügen:

Code: PHP  [Auswählen]

//BOF contact fields enhancements by sixtyseven
if (trim($_POST['name']) == '') {
        $err_msg .= ERROR_NAME;
}

$telephone = preg_replace('/[^0-9+-]/', '', trim($_POST['phone']));
if(!$telephone) {
        $err_msg .= ERROR_PHONE;
} else {
        $_POST['phone'] = $telephone;
}
//EOF contact fields enhancements by sixtyseven

In den Sprachdateien die Fehlermeldungen entsprechend definieren, z.B. für deutsch:

Code: PHP  [Auswählen]

define('ERROR_NAME','<p><b>Ihr Name:</b> Keine Eingabe!</p>'); 
define('ERROR_PHONE','<p><b>Telefon:</b> Keine oder ung&uuml;ltige Eingabe!</p>');

Nicht vergessen, im Template die beiden Felder enstprechend mit * zu kennzeichnen!